Skip to content

fix(SyncIcon): Replace SyncIcon with RhUiSyncIcon#12512

Merged
kmcfaul merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-sync-icon-with-rh-ui-sync
Jul 8, 2026
Merged

fix(SyncIcon): Replace SyncIcon with RhUiSyncIcon#12512
kmcfaul merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-sync-icon-with-rh-ui-sync

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Documentation

    • Updated the toolbar and table demo documentation to use the new sync icon component.

  • UI Updates

    • Updated the “Sync” icon in toolbar examples and the related demo app to render the new icon (RhUiSyncIcon) instead of the previous one.
    • Updated the table sortable responsive toolbar demo to use the same updated sync icon.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 04f1a63f-8014-4ecf-865a-4fbfa8ecd469

📥 Commits

Reviewing files that changed from the base of the PR and between 118af99 and 2942ab2.

📒 Files selected for processing (7)
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
  • packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarGroups.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
  • packages/react-table/src/demos/Table.md
  • packages/react-table/src/demos/examples/TableSortableResponsive.tsx
✅ Files skipped from review due to trivial changes (6)
  • packages/react-table/src/demos/Table.md
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
  • packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx
  • packages/react-table/src/demos/examples/TableSortableResponsive.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/react-core/src/components/Toolbar/examples/ToolbarGroups.tsx

Walkthrough

Across toolbar examples and demos in react-core, react-table, and react-integration, SyncIcon imports and usages are replaced with RhUiSyncIcon. No other logic, structure, or behavior changes.

Changes

SyncIcon → RhUiSyncIcon in Toolbar Examples and Demos

Layer / File(s) Summary
Icon swap across toolbar examples and demos
packages/react-core/src/components/Toolbar/examples/Toolbar.md, packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx, packages/react-core/src/components/Toolbar/examples/ToolbarGroups.tsx, packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx, packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx, packages/react-table/src/demos/Table.md, packages/react-table/src/demos/examples/TableSortableResponsive.tsx		 Each file replaces the SyncIcon import with RhUiSyncIcon and updates the matching toolbar button or example icon prop.
Estimated code review effort: 1 (Trivial) ~2 minutes

Suggested reviewers: thatblindgeye, kmcfaul, nicolethoen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: replacing SyncIcon with RhUiSyncIcon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-react-pr-12512.surge.sh

A11y report: https://pf-react-pr-12512-a11y.surge.sh

@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:13
@rebeccaalpert @cursoragent
fix(SyncIcon): Replace SyncIcon with RhUiSyncIcon
2942ab2 
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-sync-icon-with-rh-ui-sync branch from 118af99 to 2942ab2 Compare July 8, 2026 15:00
@kmcfaul kmcfaul merged commit 9829852 into patternfly:main Jul 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmcfaul kmcfaul kmcfaul approved these changes
@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rebeccaalpert @patternfly-build @kmcfaul @thatblindgeye